Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splines recover transpose #271

Merged
merged 8 commits into from
Jan 26, 2024
Merged

Splines recover transpose #271

merged 8 commits into from
Jan 26, 2024

Conversation

blegouix
Copy link
Collaborator

No description provided.

@blegouix blegouix self-assigned this Jan 23, 2024
@blegouix blegouix marked this pull request as draft January 23, 2024 15:00
@blegouix blegouix changed the base branch from main to splines-remove-batched-suffix January 25, 2024 13:44
@blegouix blegouix marked this pull request as ready for review January 25, 2024 13:45
tpadioleau
tpadioleau reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try

m_solver->transpose()->apply(to_gko_dense(gko_exec, b_subview), to_gko_dense(gko_exec, x_subview));

If it does not cost more it would a much simpler code

Base automatically changed from splines-remove-batched-suffix to main January 26, 2024 14:27
@blegouix blegouix merged commit c0e9235 into main Jan 26, 2024
42 checks passed
@blegouix blegouix deleted the splines-recover-transpose2 branch January 26, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpadioleau tpadioleau tpadioleau approved these changes

Assignees

@blegouix blegouix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blegouix @tpadioleau