Workaround ginkgo omp problem (use Gmres) #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
That is cool, do you know if it is also enough to solve issues we encountered on the Gysela side ? |
Closed
|
Yes I checked it, it is |
tpadioleau
approved these changes
Apr 2, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following ginkgo-project/ginkgo#1563 (comment)
Using Gmres avoid the problem. Stopping criteria needed to be relaxed to make all tests pass (2D splines were slightly failing which means 1e-19 leads to some kind of non-convergency. It is also in accord with recommandation here: ginkgo-project/ginkgo#1563 (comment))
OMP preconditionner parameter (Jacobi-block-size) is set to 1 again because of Ginkgo recommandation, and because we do not observe huge performance improvement on splines with preconditionner (~18% at most in old benchmarks).
BiCGStab should be recovered once the problem has been fixed from Ginkgo side.
It solves all problems we had due to this issue (in Gysela or DDC)