Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matrix_sparse.hpp #384

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Update matrix_sparse.hpp #384

merged 1 commit into from
Apr 4, 2024

Conversation

tpadioleau
Copy link
Member

Update magic number

Update magic number
@tpadioleau tpadioleau self-assigned this Apr 3, 2024
@blegouix
Copy link
Collaborator

blegouix commented Apr 4, 2024

Can you explain why you look at this ? It helps for the issue with OMP in Gysela ?

@tpadioleau tpadioleau marked this pull request as ready for review April 4, 2024 06:53
@tpadioleau
Copy link
Member Author

Yes 1e-16 was a bit too restrictive

@tpadioleau
Copy link
Member Author

tpadioleau commented Apr 4, 2024

As a rule of thumb I think the stopping criterion $||r||$ in double precision should follow $10^{-16} \approx \kappa(A) ||r||$, so for a good condition number $\kappa(A) < 100$, we should stop somewhere at $||r|| \in [10^{-15} , 10^{-14}]$.

@tpadioleau tpadioleau merged commit 4a2a7fd into main Apr 4, 2024
43 checks passed
@tpadioleau tpadioleau deleted the tpadioleau-patch-1 branch April 4, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants