Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Splines] remove rank() #413

Merged
merged 1 commit into from
Apr 18, 2024
Merged

[Splines] remove rank() #413

merged 1 commit into from
Apr 18, 2024

Conversation

blegouix
Copy link
Collaborator

rank() is a residual from an old functionning of DDC.

@blegouix blegouix self-assigned this Apr 18, 2024
tpadioleau
tpadioleau approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me

@tpadioleau tpadioleau merged commit ac05c22 into main Apr 18, 2024
43 of 44 checks passed
@tpadioleau tpadioleau deleted the remove-splines-rank branch April 18, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpadioleau tpadioleau tpadioleau approved these changes

Assignees

@blegouix blegouix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blegouix @tpadioleau