Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide base classes of dimensions #417

Merged
merged 1 commit into from
Apr 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions include/ddc/kernels/splines/bsplines_non_uniform.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

namespace ddc {

namespace detail {

template <class T>
struct NonUniformBsplinesKnots : NonUniformPointSampling<typename T::tag_type>
{
Expand All @@ -24,9 +26,11 @@ struct NonUniformBSplinesBase
{
};

} // namespace detail

/// NonUniformPointSampling specialization of BSplines
template <class Tag, std::size_t D>
class NonUniformBSplines : NonUniformBSplinesBase
class NonUniformBSplines : detail::NonUniformBSplinesBase
{
static_assert(D > 0, "Parameter `D` must be positive");

Expand Down Expand Up @@ -64,7 +68,7 @@ class NonUniformBSplines : NonUniformBSplinesBase
friend class Impl;

private:
using mesh_type = NonUniformBsplinesKnots<DDim>;
using mesh_type = detail::NonUniformBsplinesKnots<DDim>;

ddc::DiscreteDomain<mesh_type> m_domain;

Expand Down Expand Up @@ -201,7 +205,7 @@ class NonUniformBSplines : NonUniformBSplinesBase
};

template <class DDim>
struct is_non_uniform_bsplines : public std::is_base_of<NonUniformBSplinesBase, DDim>
struct is_non_uniform_bsplines : public std::is_base_of<detail::NonUniformBSplinesBase, DDim>
{
};

Expand Down
10 changes: 7 additions & 3 deletions include/ddc/kernels/splines/bsplines_uniform.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

namespace ddc {

namespace detail {

template <class T>
struct UniformBsplinesKnots : UniformPointSampling<typename T::tag_type>
{
Expand All @@ -24,8 +26,10 @@ struct UniformBSplinesBase
{
};

} // namespace detail

template <class Tag, std::size_t D>
class UniformBSplines : UniformBSplinesBase
class UniformBSplines : detail::UniformBSplinesBase
{
static_assert(D > 0, "Parameter `D` must be positive");

Expand Down Expand Up @@ -63,7 +67,7 @@ class UniformBSplines : UniformBSplinesBase
friend class Impl;

private:
using mesh_type = UniformBsplinesKnots<DDim>;
using mesh_type = detail::UniformBsplinesKnots<DDim>;

// In the periodic case, it contains twice the periodic point!!!
ddc::DiscreteDomain<mesh_type> m_domain;
Expand Down Expand Up @@ -206,7 +210,7 @@ class UniformBSplines : UniformBSplinesBase
};

template <class DDim>
struct is_uniform_bsplines : public std::is_base_of<UniformBSplinesBase, DDim>
struct is_uniform_bsplines : public std::is_base_of<detail::UniformBSplinesBase, DDim>
{
};

Expand Down
8 changes: 6 additions & 2 deletions include/ddc/non_uniform_point_sampling.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,17 @@

namespace ddc {

namespace detail {

struct NonUniformPointSamplingBase
{
};

} // namespace detail

/// `NonUniformPointSampling` models a non-uniform discretization of the `CDim` segment \f$[a, b]\f$.
template <class CDim>
class NonUniformPointSampling : NonUniformPointSamplingBase
class NonUniformPointSampling : detail::NonUniformPointSamplingBase
{
public:
using continuous_dimension_type = CDim;
Expand Down Expand Up @@ -119,7 +123,7 @@ class NonUniformPointSampling : NonUniformPointSamplingBase
};

template <class DDim>
struct is_non_uniform_sampling : public std::is_base_of<NonUniformPointSamplingBase, DDim>
struct is_non_uniform_sampling : public std::is_base_of<detail::NonUniformPointSamplingBase, DDim>
{
};

Expand Down
8 changes: 6 additions & 2 deletions include/ddc/periodic_sampling.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,18 @@

namespace ddc {

namespace detail {

struct PeriodicSamplingBase
{
};

} // namespace detail

/** PeriodicSampling models a periodic discretization of the provided continuous dimension
*/
template <class CDim>
class PeriodicSampling : PeriodicSamplingBase
class PeriodicSampling : detail::PeriodicSamplingBase
{
public:
using continuous_dimension_type = CDim;
Expand Down Expand Up @@ -231,7 +235,7 @@ class PeriodicSampling : PeriodicSamplingBase
};

template <class DDim>
struct is_periodic_sampling : public std::is_base_of<PeriodicSamplingBase, DDim>
struct is_periodic_sampling : public std::is_base_of<detail::PeriodicSamplingBase, DDim>
{
};

Expand Down
8 changes: 6 additions & 2 deletions include/ddc/uniform_point_sampling.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,18 @@

namespace ddc {

namespace detail {

struct UniformPointSamplingBase
{
};

} // namespace detail

/** UniformPointSampling models a uniform discretization of the provided continuous dimension
*/
template <class CDim>
class UniformPointSampling : UniformPointSamplingBase
class UniformPointSampling : detail::UniformPointSamplingBase
{
public:
using continuous_dimension_type = CDim;
Expand Down Expand Up @@ -200,7 +204,7 @@ class UniformPointSampling : UniformPointSamplingBase
};

template <class DDim>
struct is_uniform_sampling : public std::is_base_of<UniformPointSamplingBase, DDim>
struct is_uniform_sampling : public std::is_base_of<detail::UniformPointSamplingBase, DDim>
{
};

Expand Down
Loading