Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFT doc #535

Merged
merged 19 commits into from
Jul 20, 2024
Merged

FFT doc #535

merged 19 commits into from
Jul 20, 2024

Conversation

blegouix
Copy link
Collaborator

Closes #487

@blegouix blegouix added the documentation Improvements or additions to documentation label Jul 10, 2024
@blegouix blegouix self-assigned this Jul 10, 2024
@blegouix blegouix marked this pull request as draft July 10, 2024 11:47
blegouix
blegouix commented Jul 11, 2024
View reviewed changes
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
blegouix
blegouix commented Jul 11, 2024
View reviewed changes
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
blegouix
blegouix commented Jul 11, 2024
View reviewed changes
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
blegouix
blegouix commented Jul 11, 2024
View reviewed changes
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
blegouix
blegouix commented Jul 11, 2024
View reviewed changes
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
blegouix
blegouix commented Jul 11, 2024
View reviewed changes
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
blegouix
blegouix commented Jul 11, 2024
View reviewed changes
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
@blegouix blegouix marked this pull request as ready for review July 11, 2024 11:54
@blegouix blegouix requested a review from tpadioleau July 11, 2024 11:54
blegouix
blegouix commented Jul 11, 2024
View reviewed changes
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
blegouix
blegouix commented Jul 11, 2024
View reviewed changes
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
blegouix
blegouix commented Jul 11, 2024
View reviewed changes
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
tpadioleau
tpadioleau requested changes Jul 11, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid the word "spatial mesh", numpy fft talks about sample spacing.

include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
blegouix and others added 2 commits July 12, 2024 08:45
@blegouix @tpadioleau
Apply suggestions from code review
95f020c 
Co-authored-by: Thomas Padioleau <thomas.padioleau@cea.fr>
@blegouix
remove "spatial" terminology
6638320
blegouix
blegouix commented Jul 16, 2024
View reviewed changes
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
blegouix
blegouix commented Jul 16, 2024
View reviewed changes
include/ddc/kernels/fft.hpp Outdated Show resolved Hide resolved
@blegouix
Copy link
Collaborator Author

Draft waiting for #541

@blegouix blegouix marked this pull request as draft July 18, 2024 06:28
@blegouix blegouix marked this pull request as ready for review July 19, 2024 11:20
tpadioleau
tpadioleau approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me

@tpadioleau tpadioleau merged commit 21fa29b into main Jul 20, 2024
49 checks passed
@tpadioleau tpadioleau deleted the fft-doc branch July 20, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpadioleau tpadioleau tpadioleau approved these changes

Assignees

@blegouix blegouix

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation of fft
2 participants
@blegouix @tpadioleau