Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a batched operator() to SplineEvaluator without the coordinates argument #685

Merged
merged 8 commits into from
Nov 27, 2024
Merged

Add a batched operator() to SplineEvaluator without the coordinates argument #685

merged 8 commits into from
Nov 27, 2024

Conversation

EmilyBourne
Copy link
Collaborator

Add a batched operator() and derivative operators to SplineEvaluator and SplineEvaluator2D without the coordinates argument. Fixes #684

tpadioleau
tpadioleau reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I think we could factorize more code but it would require time to develop.

We don't have tests involving only evaluators, unless you want to design such a test, it is ok for me to merge as is.

@tpadioleau tpadioleau merged commit 6405495 into main Nov 27, 2024
55 checks passed
@tpadioleau tpadioleau deleted the 684-spline-eval-operator branch November 27, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpadioleau tpadioleau tpadioleau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a batched operator() to SplineEvaluator without the coordinates argument
2 participants
@EmilyBourne @tpadioleau