Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rank in discrete spaces #81

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Remove rank in discrete spaces #81

merged 1 commit into from
Oct 25, 2022

Conversation

tpadioleau
Copy link
Member

No description provided.

@jbigot
Copy link
Member

jbigot commented Oct 25, 2022

Ok, why not, but why?

Copy link
Member

@jbigot jbigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not

@tpadioleau
Copy link
Member Author

Well it is not used and not well defined. I would advocate to remove it. If we find it useful in the future we can totally reintroduce it.

@jbigot
Copy link
Member

jbigot commented Oct 25, 2022

Not used, I agree. Not well defined, not so much. The rank is the number of discrete dimensions introduced by each discretization, i.e. whether an order is defined over the discrete elements (1D) or whether the discrete elements are a vector of discrete elements for which an order is defined

@tpadioleau
Copy link
Member Author

Ok why not but it was not defined until now. I understand the purpose of defining the rank for a chunk/chunkspan because it tells you how many indices you need to give. However in the case of discrete spaces the purpose is not clear. For example if we want to reintroduce the UniformMesh discretization, we would introduce the node and cell discrete spaces thus making a rank 2, even if some functions are of rank 0, 1 and 2.

@tpadioleau tpadioleau merged commit 49d5e22 into main Oct 25, 2022
@tpadioleau tpadioleau deleted the deprecate-rank branch October 25, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants