Fix79: no monitoring caused tests supposed to fail to succeed instead #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a bug that resulted in some tests not failing when the cmd flag
--no-monitor
is set. Raising a BaseException in the corresponding code that runs when monitoring is disabled (line 210) solves the issue.Fixes #79
pytest-monitor.py:205
raise e
instead ofreturn e
Checklist:
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have added tests that prove my fix is effective or that my feature works- [] New and existing unit tests pass locally with my changes (not just the CI)- [ ] Any dependent changes have been merged and published in downstream modulescreate one !)
Status: Code Review Needed
,Business: Test Needed
orStatus: In Progress
if you are still working on the PR)