Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix79: no monitoring caused tests supposed to fail to succeed instead #80

Closed
wants to merge 0 commits into from

Conversation

lhpt2
Copy link

@lhpt2 lhpt2 commented May 7, 2024

Description

There was a bug that resulted in some tests not failing when the cmd flag --no-monitor is set. Raising a BaseException in the corresponding code that runs when monitoring is disabled (line 210) solves the issue.

Fixes #79

pytest-monitor.py:205 raise e instead of return e

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
  • My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [] New and existing unit tests pass locally with my changes (not just the CI)
    - [ ] Any dependent changes have been merged and published in downstream modules
  • I have provided a link to the issue this PR adresses in the Description section above (If there is none yet,
    create one !)
  • I have updated the changelog
  • I have labeled my PR using appropriate tags (in particular using status labels like Status: Code Review Needed, Business: Test Needed or Status: In Progress if you are still working on the PR)

@lhpt2 lhpt2 marked this pull request as draft May 8, 2024 08:50
@lhpt2 lhpt2 closed this May 8, 2024
@lhpt2 lhpt2 deleted the fix79-no-monitor branch May 8, 2024 12:26
@lhpt2 lhpt2 restored the fix79-no-monitor branch May 8, 2024 12:27
@lhpt2 lhpt2 reopened this May 8, 2024
@lhpt2 lhpt2 closed this May 8, 2024
@lhpt2 lhpt2 force-pushed the fix79-no-monitor branch from 622af1e to bd55b75 Compare May 8, 2024 12:33
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@lhpt2
Copy link
Author

lhpt2 commented May 8, 2024

Ran into some issues and decided to open a new PR (#81)

@lhpt2 lhpt2 deleted the fix79-no-monitor branch May 8, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--no-monitor breaks pytest.raises and django_assert_num_queries
1 participant