Updating the branch on my end #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SayDialog's WriterAudio now uses the sources provided by the speaking character or the defaults from the MusicManager. Fix // summary error in scripts Add Character variable type and PropertyCommand
Fix Variable ToSummary to null check before returning data summary
Add get logic to SetSliderValue Related to ongoing request for interaction between ui elements and Fungus.
Uses added audio commands and some variable data types. Add waits on snapshottransition commands.
constuct => construct
FIx #862 In Unity 2020.1 TMpro is auto updated to 3.0.x and there is a slight behaviour change from TMPro 2.x that requires us to be more thorough is our use of maxVisibleCharacters. Add TheExperiement_TMPro
Now forces expended values into the cached style repeatedly. In newer Unity UI we were seeing missing alignment and colour during caching
InvokeMethod now explicitily searches all assemblies to find matching fully qualified name. InvokeMethodEditor now logs error if targeted type cannot be found, rather than null ref error
Add CodeCoverage to gitignore
Update typo in PODTypeFactory.cs
v3.14.5
Add more tests, green, factored
Save Data, items, serializers are now less directly linked to savegame, but more general generic file saving. They don't include direct references to save descriptions or scenes. They now have a string pair store at the root, which is used for save desc and scene name when being used as a save game. User profile now a separate concern to savemanager, in future user profile will hold audio, graphics, language, etc. settings.
StringPair replaces SaveDataItem, as it was just a pair of strings SaveDataItemSerializer don't try to set values on objects when there are no values to set them to. Makes testing in editormode easier/possible in a number of cases. Meta now SaveGameMetaData StringPairList type introduced as similar logic existed in multiple places SaveManager separated from SaveFileManagement, only SaveManager knows about the distinction between types of save.
Add Save demo that uses additional elements of the FungusSaveSystem Factor Default save handler base class
Fixed issue with variables being modified when the key isn't valid
Portrait Move To Front Fixed
Change portrait move to front to operate on holder rather than image Bump Unity bugfix version
CommandListAdapter items and Blocks in flowchartwindow have configurable tints in fungus editor preferences
Bump up to Unity 2019.4.11
Add Slider EventHandler
Add Simple Tint preferences
Combines Get and Set commands that existed previously, makes more sense to mirror the behaivour of Fungus Property commands
Enhanced and Expanded Audio Support
Can be added to Commands, Variables, and EventHandlers. Resulting in a warning box when using them and showing a yellow [DEP] prefacing them. Add Obsolete to iTween tween commands that have existing LeanTween alternates
Add Support for Obsolete attribute
EventHandlers GetSummary is now shown in the inspector. Add editor pref to hide eventhandler and command info helpboxes
Update BlockEditor.cs to support up/down key navigation
Add EventHandler Error Box
Add Log of Location for Command Execute Exceptions
Clean todos and formatting
Add Signal for SaveMetas refreshed
Remove bool return on load, if it fails it fails loudly.
There's a lot to unpack here... - For organization, I moved a lot of the save-system-related classes to their own folders. - In SaveController.cs, I renamed smc to saveManager for better variable naming - In SaveController.cs, I fixed a bug that made the Save button useless. See the comments in the Update function - Refactored SaveSlotController to function more as a hub of sorts, where SaveSlotViews (components that display things based on save data) are what handle most of the visual aspects. - To go with the above, I created SaveSlotView subclasses to display the save slot's number, date, and description. The prefab was also altered to use them
Replace direct dep on FlowchartSaveDataItem
Previous implementation relied on order or execution, the SaveController being after the result of a UI Interaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.