CGAL improvement backported from CDT_3 branch #8170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(even if it's not strictly conforming to the C++ standard)
a range for `contexts_begin` and `contexts_end` functions.
- `IO::oformat` can display triangulations vertex handles
with point, using `With_point_tag{}` as second argument,
- improve the compatibility with C++20 `<format>`: now the precision
can be specified in the format string.
Backport: master
This enables customization of projection traits for CDT_2s and facilitates unification with the predicates utilized in 3D triangulations.
That allows to pass an integral offset to the displayed time stamps. The goal is to set it to -1, to display vertices IDs that are identical to the input vertices indices of the `Surface_mesh``.
Backport: master, 5.5.x, 5.4.x
This reverts commit ac47f30.
|
I have reverted:
I have checked again with CTest locally on the same set of tests, and it passed. |
sloriot
added
Under Testing
Tested
and removed
Batch_1
|
Successfully tested in 6.0-Ic-251 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Important various fixes and improvements, from an experimental branch of mine about CDT_3.
remove CMake warnings about(our testsuite tests with VTK-8.2, whereas VTK-9.0 was released four years ago).VTK_USE_FILECirculator_from_containercompatible with ranges (instead of just containers)Hash_mapis move-constructible and -assignable<format>Compare_angle_3(Point_3, Point_3, Point_3, Point_3, Point_3, Point_3)(with six points) TODO: needs doc... will be handled later in issue TODO list after PR #8170 CGAL improvement backported from CDT_3 branch #8219Compare_xy_2toTriangulationTraits_2TODO: needs announcementCompact_containertime stamp featureCGAL::Scope_exit,CGAL::make_scope_exit, for CGAL developers (undocumented)make_sorted_pairwith only one pair-like argumentCGAL::IO::Output_refandoformatTDS_3/include/CGAL/Triangulation_data_structure_3.h(is_edgeis 7 times faster)perf improvement inTriangulation_2/include/CGAL/Triangulation_2/internal/Polyline_constraint_hierarchy_2.h(with the use ofunordered_flat_mapfrom Boost>=1.80Triangulation_segment_cell_iterator_3Triangulation_3::is_facet(u, v, w)(without, c, i, j, k)Release Management