Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded extrastylesheet code #8331

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Remove hardcoded extrastylesheet code #8331

merged 1 commit into from
Jul 23, 2024

Conversation

albert-github
Copy link
Contributor

In the header files it was mentioned:

<!-- This should probably be an extrastylesheet instead of hardcoded. -->
<link href="$relpath$../Manual/cgal_stylesheet.css" rel="stylesheet" type="text/css" />
$extrastylesheet

this is now effectuated with this PR.

@albert-github
Remove hardcoded extrastylesheet code
524ac0c 
In the header files it was mentioned:
```
<!-- This should probably be an extrastylesheet instead of hardcoded. -->
<link href="$relpath$../Manual/cgal_stylesheet.css" rel="stylesheet" type="text/css" />
$extrastylesheet
```
this is now effectuated with this PR.
@sloriot
Copy link
Member

sloriot commented Jul 8, 2024

Successfully tested in CGAL-6.0-Ic-282

@sloriot sloriot added this to the 6.0 milestone Jul 23, 2024
@sloriot sloriot merged commit 62de71b into CGAL:master Jul 23, 2024
8 checks passed
@albert-github albert-github deleted the feature/bug_cgal_stylesheet branch July 23, 2024 16:17
lrineau added a commit to lrineau/cgal that referenced this pull request Dec 16, 2024
@lrineau
cgal_stylesheet.css must be taken from ../Manual
a1aba2b 
Revert "Merge pull request CGAL#8331 from albert-github/feature/bug_cgal_stylesheet"

This reverts commit 62de71b, reversing
changes made to 3b4349c.
lrineau added a commit to lrineau/cgal that referenced this pull request Dec 17, 2024
@lrineau
cgal_stylesheet.css must be taken from ../Manual
2a50c1f 
Revert "Merge pull request CGAL#8331 from albert-github/feature/bug_cgal_stylesheet"

This reverts commit 62de71b, reversing
changes made to 3b4349c.
@lrineau lrineau mentioned this pull request Dec 17, 2024
Merged
@lrineau
Copy link
Member

lrineau commented Dec 17, 2024

@albert-github I had to revert this PR, in #8665, because cgal_stylesheet.css must be included from ../Manual.

@lrineau lrineau added the reverted pull-request that was merged but eventually reverted label Dec 17, 2024
lrineau added a commit to lrineau/cgal that referenced this pull request Dec 17, 2024
@lrineau
cgal_stylesheet.css must be taken from ../Manual
a269cd3 
Revert "Merge pull request CGAL#8331 from albert-github/feature/bug_cgal_stylesheet"

This reverts commit 62de71b, reversing
changes made to 3b4349c.
@albert-github
Copy link
Contributor Author

See my comment wit #8665, I don't see a reason why it is necessary that

cgal_stylesheet.css must be included from ../Manual.

lrineau added a commit that referenced this pull request Jan 6, 2025
@lrineau
Doxygen: fix doc compilation with Doxygen 1.10 or later (#8665)
e9a2365 
- Introduce container images for Doxygen.
- Ensure compatibility with Doxygen 1.10 and later.
- Revert previous stylesheet changes to restore the correct stylesheet
path (reverts #8331).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Doc Enhancement Merged_in_6.0 reverted pull-request that was merged but eventually reverted Tested
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@albert-github @sloriot @lrineau