Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Update/Deprecate an AWS Thing Type #1805

Closed
Tracked by #1865
hocinehacherouf opened this issue Feb 26, 2023 · 0 comments · Fixed by #2050
Closed
Tracked by #1865

Task: Update/Deprecate an AWS Thing Type #1805

hocinehacherouf opened this issue Feb 26, 2023 · 0 comments · Fixed by #2050
Assignees
Labels

Comments

@hocinehacherouf
Copy link
Contributor

hocinehacherouf commented Feb 26, 2023

Is your feature request related to a problem? Please describe.
Blocked by #1802 and #1806

A thing type cannot be updated but users must be able to view it data and deprecate it at any time to prevent new things from being associated with it.

Documentation: https://docs.aws.amazon.com/iot/latest/developerguide/thing-types.html

Describe the solution you'd like

Users can only deprecate a thing type

Backend:

  • Create/update a service that:
    • Sends a request to AWS to deprecate a thing type: You can use the method DeprecateThingTypeAsync to do that
    • If the request is successful, the thing type should be updated on database using EF (deprecated flag on table)
    • Otherwise an exception should thrown with a human readable message
  • Create a REST endpoint that allow HTTP clients to deprecate a thing type
    • ⚠️ Use DTO for data exchange between controllers and services layers. Controllers should never handle AWS or internal objects.

Frontend:

  • Create a new view to allow users to view a thing type and to deprecate it
  • Users must be able alerted when an exception occurs
  • The view should also allow to delete the thing type when it is deprecated
@github-project-automation github-project-automation bot moved this to 📝 Todo in IoT Hub Portal Feb 26, 2023
@hocinehacherouf hocinehacherouf changed the title Feature: Update an AWS Thing Type Feature: Update/Deprecate an AWS Thing Type Feb 26, 2023
@kbeaugrand kbeaugrand changed the title Feature: Update/Deprecate an AWS Thing Type Task: Update/Deprecate an AWS Thing Type Mar 11, 2023
@ssgueye2 ssgueye2 self-assigned this Apr 28, 2023
@ssgueye2 ssgueye2 moved this from 📝 Todo to 🚧 In Progress in IoT Hub Portal May 9, 2023
@ssgueye2 ssgueye2 moved this from 🚧 In Progress to 💬 Ready for Review in IoT Hub Portal May 11, 2023
@kbeaugrand kbeaugrand linked a pull request May 11, 2023 that will close this issue
9 tasks
@kbeaugrand kbeaugrand moved this from 💬 Ready for Review to 🚀 Ready in IoT Hub Portal May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🚀 Ready
Development

Successfully merging a pull request may close this issue.

4 participants