Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: HttpClient is not correctly injected in LoRaWanManagementService #2942

Closed
kbeaugrand opened this issue Apr 16, 2024 · 0 comments · Fixed by #2943
Closed

Bug: HttpClient is not correctly injected in LoRaWanManagementService #2942

kbeaugrand opened this issue Apr 16, 2024 · 0 comments · Fixed by #2943
Labels
bug Something isn't working

Comments

@kbeaugrand
Copy link
Member

Expected Behavior

When using the DI to get the httpClient for the lorawan management facade, its settings should be populated by the configuration.

Current Behavior

Currently the application is getting a default httpclient without his parameters, this cause an issue when trying to send a frame to the device.

Steps to Reproduce

  1. Try to send a LoraWAN downsteam frame.

Context (Environment)

Portal version: 5.2.0
LoRaWAN Stack version: N/A

Logs

Additional Information
@kbeaugrand kbeaugrand added the bug Something isn't working label Apr 16, 2024
@github-project-automation github-project-automation bot moved this to 📝 Todo in IoT Hub Portal Apr 16, 2024
kbeaugrand added a commit that referenced this issue Apr 16, 2024
@kbeaugrand
Fix #2942 - Add LoraWan service dependency before adding the http cli…
1004229 
…ent.
@kbeaugrand kbeaugrand moved this from 📝 Todo to 💬 Ready for Review in IoT Hub Portal Apr 16, 2024
@kbeaugrand kbeaugrand mentioned this issue Apr 16, 2024
Merged
9 tasks
kbeaugrand added a commit that referenced this issue Apr 16, 2024
@kbeaugrand
Fix #2942 - Add LoraWan service dependency before adding the http cli…
c24fa67 
…ent.
kbeaugrand added a commit that referenced this issue Apr 16, 2024
@kbeaugrand
Fix #2942 - Add LoraWan service dependency before adding the http cli…
3ba5994 
…ent.
kbeaugrand added a commit that referenced this issue Apr 16, 2024
@kbeaugrand
Fix #2942 - Add LoraWan service dependency before adding the http cli…
6431fc4 
…ent.
kbeaugrand added a commit that referenced this issue Apr 16, 2024
@kbeaugrand
Fix #2942 - Add LoraWan service dependency before adding the http cli…
ed3da0e 
…ent. (#2943)
kbeaugrand added a commit that referenced this issue Apr 16, 2024
@kbeaugrand
Fix #2942 - Add LoraWan service dependency before adding the http cli…
f50c12a 
…ent. (#2943)
@kbeaugrand kbeaugrand mentioned this issue Apr 16, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
IoT Hub Portal
Status: 💬 Ready for Review
Milestone
No milestone
1 participant
@kbeaugrand