Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: startupOrder not supported in Edge Device Model schema #3023

Open
Metal-Mighty opened this issue May 30, 2024 · 1 comment
Open

Bug: startupOrder not supported in Edge Device Model schema #3023

Metal-Mighty opened this issue May 30, 2024 · 1 comment
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@Metal-Mighty
Copy link
Contributor

Expected Behavior

I should be able to specify the startupOrder parameter in the Edge Device Model schema in order for it to be applied in the Azure IoT Hub deployment

Current Behavior

The startupOrder parameter isn't supported in the portal's API endpoint body, it is ignored if you add it to the schema.

Steps to Reproduce

  1. Get an existing Edge Device model schema or create a new one
  2. Add a startupOrder parameter in the edgeModule parameters
  3. Push the model to the portal
  4. In Azure, the deployment model doesn't have the startupOrder parameters defined

Context (Environment)

Portal version:
LoRaWAN Stack version:

Logs

Additional Information

@Metal-Mighty Metal-Mighty added the bug Something isn't working label May 30, 2024
@github-project-automation github-project-automation bot moved this to 🔦 Triage in IoT Hub Portal May 30, 2024
@Metal-Mighty Metal-Mighty moved this from 🔦 Triage to 📝 Todo in IoT Hub Portal May 30, 2024
@Metal-Mighty Metal-Mighty added this to the v6.0 milestone May 30, 2024
@Metal-Mighty Metal-Mighty added the good first issue Good for newcomers label Aug 12, 2024
@judramos judramos self-assigned this Dec 3, 2024
@judramos judramos moved this from 📝 Todo to 🚧 In Progress in IoT Hub Portal Dec 3, 2024
@judramos
Copy link

judramos commented Dec 3, 2024

There is actually a bug when an edge model is created using API: the Json property name for properties is set with a lowercase letter, but when saving to Azure the first letter is capitalized. Then the list of modules is not recognized.
This problem is due to the following task: #3175 Moving usings to GlobalUsing.cs #3186, when the use of Newtonsoft.Json was changed to System.Text.Json on some models.

kbeaugrand added a commit that referenced this issue Dec 5, 2024
* Add of layerId in device twin

* #2998 Quartz migration for SendPlanningCommand

* #2856 Disable built-in device model deletion

* #3238 Update view when a device is unchecked

* 3239 Allow to delete a planning from client

* 3239 Allow to delete a planning

* 2998 Schedule commands

* #3239 Change checkboxes for layers displayed

* Merge from main

* 2516 add supportLoRaFeatures tag in template file

* #3250 Import device list using the template given

* #2985 Batch import creates ABP tags in Device Twin for OTAA-based device models

* #3251 Import device - data overwritten

* Unit tests

* Update src/IoTHub.Portal.Infrastructure/Jobs/SendPlanningCommandJob.cs

Co-authored-by: Kevin BEAUGRAND <9513635+kbeaugrand@users.noreply.github.com>

* #2958 Remove 'Connection State' and 'Last status update' columns

* #3023 startupOrder not supported in Edge Device Model schema

---------

Co-authored-by: E068097 <julie.ramos_ext@michelin.com>
Co-authored-by: judramos <ramos.julie.63@gmail.com>
kbeaugrand added a commit that referenced this issue Dec 5, 2024
* Add of layerId in device twin

* #2998 Quartz migration for SendPlanningCommand

* #2856 Disable built-in device model deletion

* #3238 Update view when a device is unchecked

* 3239 Allow to delete a planning from client

* 3239 Allow to delete a planning

* 2998 Schedule commands

* #3239 Change checkboxes for layers displayed

* Merge from main

* 2516 add supportLoRaFeatures tag in template file

* #3250 Import device list using the template given

* #2985 Batch import creates ABP tags in Device Twin for OTAA-based device models

* #3251 Import device - data overwritten

* Unit tests

* Update src/IoTHub.Portal.Infrastructure/Jobs/SendPlanningCommandJob.cs

Co-authored-by: Kevin BEAUGRAND <9513635+kbeaugrand@users.noreply.github.com>

* #2958 Remove 'Connection State' and 'Last status update' columns

* #3023 startupOrder not supported in Edge Device Model schema

---------

Co-authored-by: E068097 <julie.ramos_ext@michelin.com>
Co-authored-by: judramos <ramos.julie.63@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: 🚧 In Progress
Development

No branches or pull requests

2 participants