Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #981 - Refactor LoRaWAN device controller #1134

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Aug 27, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner August 27, 2022 15:03
@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Base: 86.13% // Head: 86.14% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9581542) compared to base (302b9f1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1134   +/-   ##
=======================================
  Coverage   86.13%   86.14%           
=======================================
  Files         197      198    +1     
  Lines        6659     6667    +8     
=======================================
+ Hits         5736     5743    +7     
- Misses        923      924    +1     
Impacted Files Coverage Δ
...ntrollers/v1.0/LoRaWAN/LoRaWANDevicesController.cs 100.00% <100.00%> (ø)
...Hub.Portal/Server/Services/LoRaWANDeviceService.cs 100.00% <100.00%> (ø)
...l/Server/Controllers/v1.0/DevicesControllerBase.cs 96.87% <0.00%> (-0.79%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand force-pushed the refactor/981_move_business_code_from_lorawan_device_controller_to_service branch from 3e88899 to 9581542 Compare August 27, 2022 15:19
@kbeaugrand kbeaugrand enabled auto-merge (squash) August 27, 2022 15:21
@kbeaugrand kbeaugrand disabled auto-merge August 27, 2022 16:18
@kbeaugrand kbeaugrand merged commit e94ffb6 into main Aug 27, 2022
@kbeaugrand kbeaugrand deleted the refactor/981_move_business_code_from_lorawan_device_controller_to_service branch August 27, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor LoRaWanDevicesController
1 participant