Move Device model property to database #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/AzureIoTHub.Portal/Server/Controllers/v1.0/DeviceModelPropertiesControllerBase.cs
Fixed
Show fixed
Hide fixed
kbeaugrand
force-pushed
the
v3/add_device_model_properties_to_database
branch
from
75535e6 to
1753f32
Compare
kbeaugrand
force-pushed
the
v3/add_device_model_properties_to_database
branch
from
1753f32 to
0f2745b
Compare
Codecov ReportBase: 86.58% // Head: 85.82% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v3/main #1155 +/- ##
===========================================
- Coverage 86.58% 85.82% -0.76%
===========================================
Files 202 204 +2
Lines 6760 6753 -7
===========================================
- Hits 5853 5796 -57
- Misses 907 957 +50
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Comment on lines
+34
to
+37
| catch (InvalidOperationException) | ||
| { | ||
|
|
||
| } |
Check notice
Code scanning / CodeQL
Poor error handling: empty catch block
9 tasks
kbeaugrand
added a commit
that referenced
this pull request
Sep 5, 2022
kbeaugrand
added a commit
that referenced
this pull request
Sep 7, 2022
kbeaugrand
added a commit
that referenced
this pull request
Sep 9, 2022
kbeaugrand
added a commit
that referenced
this pull request
Sep 9, 2022
kbeaugrand
added a commit
that referenced
this pull request
Sep 9, 2022
* Add target branche to CI actions * Add PostgreSQL database to deployment (#1112) * Add PostgreSQL database to deployment * Add ARM lint task to v3-dev branch * Add github actions to solution file * Feature/add pgsql database connection (#1121) * Add entityframework + PGSql nuget packages * Add PGSql database context + initial database creation * Add Quartz.NET Scheduler to server (#1135) * Ignore migration files to code coverage * Migrate v3-dev to v3/main branch * Add unit of work and generic repository (#1154) * Add unit of work and generic repository * Add infrastructure layer + domain layer * Move Device model property to database (#1155) * Fix #984 - Refactor DeviceModelPropertiesController (#1159) * Rebase from main * Remove start Azurite from the build pipeline * Add database servcie as adependency to iot hub portal #1175 * Fix PostgreSQL arm deployment on V3 (#1183) * Feature: Add PostgreSQL login/password fields to arm ui form #1181 * Fix postgsql arm deployment #1180 * Update temporary arm templates urls for testing * Update arm templates url to target main branch * Set pgsqlAdminPassword parameter as securestring (#1188) Co-authored-by: Hocine Hacherouf <hacherouf.hocine@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's new?
What kind of change does this PR introduce?