Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/#982_-_Refactor device configurations controller #1169

Merged
merged 6 commits into from
Sep 8, 2022

Conversation

Sben65
Copy link
Contributor

@Sben65 Sben65 commented Sep 8, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Base: 87.62% // Head: 87.65% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (faa78e8) compared to base (b56d262).
Patch coverage: 98.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1169      +/-   ##
==========================================
+ Coverage   87.62%   87.65%   +0.03%     
==========================================
  Files         200      201       +1     
  Lines        6754     6774      +20     
==========================================
+ Hits         5918     5938      +20     
  Misses        836      836              
Impacted Files Coverage Δ
...ers/v1.0/LoRaWAN/LoRaWANConcentratorsController.cs 91.66% <ø> (ø)
...tal/Server/Services/DeviceConfigurationsService.cs 98.50% <98.50%> (ø)
...Controllers/v1.0/DeviceConfigurationsController.cs 100.00% <100.00%> (+1.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sben65 Sben65 marked this pull request as ready for review September 8, 2022 09:25
@Sben65 Sben65 requested a review from a team as a code owner September 8, 2022 09:25
@Sben65 Sben65 force-pushed the Refactor/#982_DeviceConfigurationsController branch from 103cdc9 to faa78e8 Compare September 8, 2022 09:30
@kbeaugrand kbeaugrand merged commit 597411e into main Sep 8, 2022
@kbeaugrand kbeaugrand deleted the Refactor/#982_DeviceConfigurationsController branch September 8, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor DeviceConfigurationsController
2 participants