Refactor DevicesControllerBase #986 #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hocinehacherouf
changed the title
Codecov ReportBase: 87.92% // Head: 87.96% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1172 +/- ##
==========================================
+ Coverage 87.92% 87.96% +0.03%
==========================================
Files 217 217
Lines 6923 6920 -3
==========================================
Hits 6087 6087
+ Misses 836 833 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| var deviceId = Guid.NewGuid().ToString(); | ||
|
|
||
| _ = this.mockRegistryManager.Setup(c => c.GetTwinAsync(It.Is<string>(x => x == deviceId))) | ||
| .ReturnsAsync((Twin)null); |
Check warning
Code scanning / CodeQL
Useless upcast
kbeaugrand
force-pushed
the
feature/986_refactor_device_controller_base
branch
from
5236326 to
456520c
Compare
audserraCGI
force-pushed
the
feature/986_refactor_device_controller_base
branch
from
d790ce7 to
224fb72
Compare
| var service = CreateService(); | ||
| var deviceId = Guid.NewGuid().ToString(); | ||
| _ = this.mockRegistryManager.Setup(c => c.GetDeviceAsync(It.IsAny<string>())) | ||
| .ReturnsAsync((Device)null); |
Check warning
Code scanning / CodeQL
Useless upcast
hocinehacherouf
deleted the
feature/986_refactor_device_controller_base
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's new?
What kind of change does this PR introduce?