Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define EdgeHub routes in edge models #1173

Merged

Conversation

audserraCGI
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Base: 87.65% // Head: 87.92% // Increases project coverage by +0.26% 🎉

Coverage data is based on head (bba4f50) compared to base (cd15cf8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
+ Coverage   87.65%   87.92%   +0.26%     
==========================================
  Files         201      203       +2     
  Lines        6774     6891     +117     
==========================================
+ Hits         5938     6059     +121     
+ Misses        836      832       -4     
Impacted Files Coverage Δ
...Client/Pages/EdgeModels/CreateEdgeModelsPage.razor 78.35% <100.00%> (+4.60%) ⬆️
.../Client/Pages/EdgeModels/EdgeModelDetailPage.razor 81.45% <100.00%> (+6.68%) ⬆️
....Portal/Client/Validators/IoTEdgeRouteValidator.cs 100.00% <100.00%> (ø)
.../AzureIoTHub.Portal/Server/Helpers/ConfigHelper.cs 85.56% <100.00%> (+2.13%) ⬆️
...ureIoTHub.Portal/Server/Mappers/EdgeModelMapper.cs 95.45% <100.00%> (+0.10%) ⬆️
...zureIoTHub.Portal/Server/Services/ConfigService.cs 100.00% <100.00%> (ø)
...eIoTHub.Portal/Server/Services/EdgeModelService.cs 97.68% <100.00%> (+0.01%) ⬆️
...reIoTHub.Portal/Shared/Models/v1.0/IoTEdgeModel.cs 100.00% <100.00%> (ø)
...reIoTHub.Portal/Shared/Models/v1.0/IoTEdgeRoute.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@audserraCGI audserraCGI force-pushed the feature/1140_define_edgehub_routes_in_edge_modules branch from b2ef2e3 to e13006e Compare September 9, 2022 08:31
@audserraCGI audserraCGI marked this pull request as ready for review September 9, 2022 13:35
@audserraCGI audserraCGI requested a review from a team as a code owner September 9, 2022 13:35
@hocinehacherouf hocinehacherouf force-pushed the feature/1140_define_edgehub_routes_in_edge_modules branch from 40b1411 to bba4f50 Compare September 9, 2022 14:55
@hocinehacherouf hocinehacherouf enabled auto-merge (squash) September 9, 2022 14:55
@hocinehacherouf hocinehacherouf merged commit b1d1971 into main Sep 9, 2022
@hocinehacherouf hocinehacherouf deleted the feature/1140_define_edgehub_routes_in_edge_modules branch September 9, 2022 15:07
Sben65 added a commit that referenced this pull request Oct 19, 2022
Sben65 added a commit that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Define EdgeHub routes in edge models
2 participants