Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1200 - Add Metrics services to Quartz Jobs #1203

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Sep 11, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner September 11, 2022 10:40
@kbeaugrand kbeaugrand force-pushed the fix/1200_migrate_scheduled_jobs_to_quartz branch from eeacb45 to c06ce50 Compare September 11, 2022 10:43
@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Base: 88.43% // Head: 88.23% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (c06ce50) compared to base (be32ea1).
Patch coverage: 70.90% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1203      +/-   ##
==========================================
- Coverage   88.43%   88.23%   -0.20%     
==========================================
  Files         209      210       +1     
  Lines        6952     6921      -31     
==========================================
- Hits         6148     6107      -41     
- Misses        804      814      +10     
Impacted Files Coverage Δ
...l/Server/Extensions/QuartzConfiguratorExtension.cs 0.00% <0.00%> (ø)
...rver/Services/ConcentratorMetricExporterService.cs 100.00% <100.00%> (+5.88%) ⬆️
...Server/Services/ConcentratorMetricLoaderService.cs 100.00% <100.00%> (+2.38%) ⬆️
...tal/Server/Services/DeviceMetricExporterService.cs 100.00% <100.00%> (+5.88%) ⬆️
...ortal/Server/Services/DeviceMetricLoaderService.cs 100.00% <100.00%> (+2.38%) ⬆️
...Server/Services/EdgeDeviceMetricExporterService.cs 100.00% <100.00%> (+5.26%) ⬆️
...l/Server/Services/EdgeDeviceMetricLoaderService.cs 100.00% <100.00%> (+1.81%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand merged commit 80231c8 into main Sep 11, 2022
@kbeaugrand kbeaugrand deleted the fix/1200_migrate_scheduled_jobs_to_quartz branch September 11, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Migrate Metrics Loader to Quartz.NET Services
1 participant