Feature/1211 migrate device models from st table to database #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 88.16% // Head: 87.94% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1215 +/- ##
==========================================
- Coverage 88.16% 87.94% -0.22%
==========================================
Files 211 213 +2
Lines 6927 6944 +17
==========================================
Hits 6107 6107
- Misses 820 837 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+22
to
+51
| foreach (var item in table.Query<TableEntity>().ToArray()) | ||
| { | ||
| if (await set.AnyAsync(c => c.Id == item.RowKey)) | ||
| continue; | ||
|
|
||
| #pragma warning disable CS8629 // Nullable value type may be null. | ||
| _ = await set.AddAsync(new DeviceModel | ||
| { | ||
| Id = item.RowKey, | ||
| Name = item[nameof(DeviceModel.Name)]?.ToString(), | ||
| Description = item[nameof(DeviceModel.Description)]?.ToString(), | ||
| IsBuiltin = bool.Parse(item[nameof(DeviceModel.IsBuiltin)]?.ToString() ?? "false"), | ||
| SupportLoRaFeatures = bool.Parse(item[nameof(DeviceModel.SupportLoRaFeatures)]?.ToString() ?? "false"), | ||
| ABPRelaxMode = bool.TryParse(item[nameof(DeviceModel.ABPRelaxMode)]?.ToString(), out var abpRelaxMode) ? abpRelaxMode : null, | ||
| Deduplication = Enum.TryParse<DeduplicationMode>(item[nameof(DeviceModel.Deduplication)]?.ToString(), out var deduplication) ? deduplication : null, | ||
| Downlink = bool.TryParse(item[nameof(DeviceModel.Downlink)]?.ToString(), out var downLink) ? downLink : null, | ||
| KeepAliveTimeout = int.TryParse(item[nameof(DeviceModel.KeepAliveTimeout)]?.ToString(), out var keepAliveTimeout) ? keepAliveTimeout : null, | ||
| PreferredWindow = int.TryParse(item[nameof(DeviceModel.PreferredWindow)]?.ToString(), out var preferredWindow) ? preferredWindow : null, | ||
| RXDelay = int.TryParse(item[nameof(DeviceModel.PreferredWindow)]?.ToString(), out var rxDelay) ? rxDelay : null, | ||
| UseOTAA = bool.TryParse(item[nameof(DeviceModel.UseOTAA)]?.ToString(), out var useOTAA) ? useOTAA : null, | ||
| AppEUI = item[nameof(DeviceModel.AppEUI)]?.ToString(), | ||
| SensorDecoder = item[nameof(DeviceModel.SensorDecoder)]?.ToString() | ||
| }); | ||
| #pragma warning restore CS8629 // Nullable value type may be null. | ||
|
|
||
| if (config is ProductionConfigHandler) | ||
| { | ||
| _ = await table.DeleteEntityAsync(item.PartitionKey, item.RowKey); | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where
kbeaugrand
force-pushed
the
feature/1211_migrate_device_models_from_st_table_to_database
branch
from
2088dd8 to
4f471b6
Compare
kbeaugrand
approved these changes
Sep 11, 2022
kbeaugrand
deleted the
feature/1211_migrate_device_models_from_st_table_to_database
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's new?
Remark : The column
SensorDecoderURLin tableDeviceTemplateswon't be migrated. It is no more used by Portal and replaced by the columnSensorDecoderWhat kind of change does this PR introduce?