Feature/1030 sync devices between iot hub and portal #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 88.29% // Head: 88.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1279 +/- ##
==========================================
+ Coverage 88.29% 88.51% +0.21%
==========================================
Files 226 232 +6
Lines 6828 7024 +196
==========================================
+ Hits 6029 6217 +188
- Misses 799 807 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hocinehacherouf
force-pushed
the
feature/1030_sync_devices_between_iot_hub_and_portal
branch
from
0fc82c2 to
ee1cc5d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| .ReturnsAsync(expectedDeviceModel); | ||
|
|
||
| _ = this.mockDeviceRepository.Setup(repository => repository.GetByIdAsync(expectedTwinDevice.DeviceId)) | ||
| .ReturnsAsync((Device)null); |
Check warning
Code scanning / CodeQL
Useless upcast
| .ReturnsAsync(expectedDeviceModel); | ||
|
|
||
| _ = this.mockLorawanDeviceRepository.Setup(repository => repository.GetByIdAsync(expectedTwinDevice.DeviceId)) | ||
| .ReturnsAsync((LorawanDevice)null); |
Check warning
Code scanning / CodeQL
Useless upcast
Comment on lines
+58
to
+61
| catch (Exception e) | ||
| { | ||
| this.logger.LogError(e, "Sync devices job has failed"); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
hocinehacherouf
force-pushed
the
feature/1030_sync_devices_between_iot_hub_and_portal
branch
from
eabb6d5 to
0d21d7e
Compare
kbeaugrand
requested changes
Sep 27, 2022
src/AzureIoTHub.Portal.Infrastructure/DevelopmentConfigHandler.cs
Outdated
Show resolved
Hide resolved
src/AzureIoTHub.Portal.Infrastructure/ProductionConfigHandler.cs
Outdated
Show resolved
Hide resolved
src/AzureIoTHub.Portal.Tests.Unit/Infrastructure/DevelopmentConfigHandlerTests.cs
Outdated
Show resolved
Hide resolved
src/AzureIoTHub.Portal.Tests.Unit/Infrastructure/ProductionConfigHandlerTests.cs
Outdated
Show resolved
Hide resolved
kbeaugrand
force-pushed
the
feature/1030_sync_devices_between_iot_hub_and_portal
branch
from
0d21d7e to
1b333f4
Compare
kbeaugrand
approved these changes
Sep 27, 2022
kbeaugrand
deleted the
feature/1030_sync_devices_between_iot_hub_and_portal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's new?
Remark: @Sben65, this PR replaces #1276 due an issue on the branch name that prevent git to see it.
What kind of change does this PR introduce?