Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing mapping on ClassType between lorawan and twin #1274 #1286

Merged

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 88.29% // Head: 88.29% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (6602d8f) compared to base (e5f2135).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1286   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files         226      226           
  Lines        6827     6828    +1     
=======================================
+ Hits         6028     6029    +1     
  Misses        799      799           
Impacted Files Coverage Δ
...reIoTHub.Portal/Server/Mappers/LoRaDeviceMapper.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hocinehacherouf hocinehacherouf marked this pull request as ready for review September 26, 2022 17:22
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner September 26, 2022 17:22
@kbeaugrand kbeaugrand merged commit 021c811 into main Sep 27, 2022
@kbeaugrand kbeaugrand deleted the bugfix/1274_add_missing_mapping_on_classtype_lorawan_device branch September 27, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: The property ClassType of a lorawan device is not mapped to a twin device
2 participants