Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic pagination on generic repository #1304 #1305

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 88.73% // Head: 88.76% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (fe4962d) compared to base (ce82f4e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1305      +/-   ##
==========================================
+ Coverage   88.73%   88.76%   +0.03%     
==========================================
  Files         241      241              
  Lines        7356     7370      +14     
==========================================
+ Hits         6527     6542      +15     
+ Misses        829      828       -1     
Impacted Files Coverage Δ
...l.Infrastructure/Repositories/GenericRepository.cs 100.00% <100.00%> (ø)
...oTHub.Portal/Shared/Models/v1.0/PaginatedResult.cs 100.00% <100.00%> (+6.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hocinehacherouf hocinehacherouf marked this pull request as ready for review October 3, 2022 14:42
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner October 3, 2022 14:42
@hocinehacherouf hocinehacherouf force-pushed the feature/1304_add_generic_pagination branch from 949fee3 to fe4962d Compare October 4, 2022 07:25
@hocinehacherouf hocinehacherouf merged commit 2a6900e into main Oct 4, 2022
@hocinehacherouf hocinehacherouf deleted the feature/1304_add_generic_pagination branch October 4, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add pagination on Generic Repository
2 participants