Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Add missing next page on concentrators listing #1365

Merged

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 89.00% // Head: 89.21% // Increases project coverage by +0.20% 🎉

Coverage data is based on head (0005348) compared to base (de5ef92).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1365      +/-   ##
==========================================
+ Coverage   89.00%   89.21%   +0.20%     
==========================================
  Files         250      250              
  Lines        7731     7739       +8     
==========================================
+ Hits         6881     6904      +23     
+ Misses        850      835      -15     
Impacted Files Coverage Δ
...ers/v1.0/LoRaWAN/LoRaWANConcentratorsController.cs 100.00% <100.00%> (ø)
...oTHub.Portal/Server/Mappers/ConcentratorProfile.cs 100.00% <100.00%> (ø)
...rtal/Server/Services/LoRaWANConcentratorService.cs 100.00% <100.00%> (ø)
...oTHub.Portal/Shared/Models/v1.0/PaginatedResult.cs 100.00% <100.00%> (ø)
...l/Server/Controllers/v1.0/DevicesControllerBase.cs 98.82% <0.00%> (+17.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hocinehacherouf hocinehacherouf marked this pull request as ready for review October 17, 2022 13:17
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner October 17, 2022 13:17
@hocinehacherouf hocinehacherouf merged commit 7102d88 into main Oct 17, 2022
@hocinehacherouf hocinehacherouf deleted the bugfix/1348_add_missing_next_page_on_concentrator_listing branch October 17, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Pagination on concentrators does not return next page value
2 participants