Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1902 - Fix query search parameters in lorawan concentrator list page #1918

Merged
merged 1 commit into from
Mar 18, 2023

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Mar 18, 2023

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand temporarily deployed to E2E March 18, 2023 15:02 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand force-pushed the fix/1902-fix-search-concentrator branch from d15044a to 99a33f5 Compare March 18, 2023 15:08
@kbeaugrand kbeaugrand temporarily deployed to E2E March 18, 2023 15:08 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@ee40e2f). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1918   +/-   ##
=======================================
  Coverage        ?   91.58%           
=======================================
  Files           ?      277           
  Lines           ?     9063           
  Branches        ?        0           
=======================================
  Hits            ?     8300           
  Misses          ?      763           
  Partials        ?        0           
Impacted Files Coverage Δ
.../Components/Concentrators/ConcentratorSearch.razor 100.00% <100.00%> (ø)
...Hub.Portal.Client/Models/ConcentratorSearchInfo.cs 100.00% <100.00%> (ø)
...es/LoRaWAN/Concentrator/ConcentratorListPage.razor 69.56% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand marked this pull request as ready for review March 18, 2023 15:15
@kbeaugrand kbeaugrand requested a review from a team as a code owner March 18, 2023 15:15
@kbeaugrand kbeaugrand merged commit 4dbeb05 into main Mar 18, 2023
@kbeaugrand kbeaugrand deleted the fix/1902-fix-search-concentrator branch March 18, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Concentrator search panel
1 participant