Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding TagsPage scenario #1920

Merged
merged 4 commits into from
Mar 19, 2023
Merged

Adding TagsPage scenario #1920

merged 4 commits into from
Mar 19, 2023

Conversation

yassir-ai
Copy link
Contributor

Description

What's new?
#1485

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@yassir-ai yassir-ai requested a review from a team as a code owner March 19, 2023 15:37
@yassir-ai yassir-ai changed the title Adding TagsPAge scenario Adding TagsPage scenario Mar 19, 2023
@codecov
Copy link

codecov bot commented Mar 19, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (336f2ec) 91.58% compared to head (6473bc9) 91.58%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1920   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files         277      277           
  Lines        9063     9063           
=======================================
  Hits         8300     8300           
  Misses        763      763

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

kbeaugrand
kbeaugrand requested changes Mar 19, 2023
View reviewed changes
src/AzureIoTHub.Portal.Tests.E2E/DeviceTags.cs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this class "TagsConfiguration"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/AzureIoTHub.Portal.Tests.E2E/Pages/TagsPage.cs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this class "TagsConfigurationPage"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done

src/AzureIoTHub.Portal.Tests.E2E/DeviceTags.cs Outdated Show resolved Hide resolved
@kbeaugrand kbeaugrand merged commit 8823f73 into CGI-FR:main Mar 19, 2023
@kbeaugrand
Copy link
Member

LGTM : E2E tests did not pass since it's coming from a fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Achraf-Git-dev Achraf-Git-dev Achraf-Git-dev left review comments

@kbeaugrand kbeaugrand kbeaugrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yassir-ai @kbeaugrand @Achraf-Git-dev