Feature: Add redirect button on snackbar when http status code is 401 #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2333 +/- ##
==========================================
+ Coverage 88.43% 88.46% +0.02%
==========================================
Files 296 296
Lines 11314 11338 +24
==========================================
+ Hits 10006 10030 +24
Misses 1308 1308
☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+142
to
+146
| .Respond(System.Net.HttpStatusCode.Unauthorized, new StringContent( | ||
| JsonConvert.SerializeObject(problemDetailsWithExceptionDetails), | ||
| Encoding.UTF8, | ||
| MediaTypeNames.Application.Json)); |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable
src/IoTHub.Portal.Tests.Unit/Client/Handlers/ProblemDetailsHandlerTests.cs
Fixed
Show fixed
Hide fixed
Comment on lines
+153
to
+156
| var httpClient = new HttpClient(problemDetailsHandler) | ||
| { | ||
| BaseAddress = new Uri("http://fake.com") | ||
| }; |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable
hocinehacherouf
force-pushed
the
Feature/2193_redirect_to_login_when_token_expired
branch
from
763ff34 to
931ad15
Compare
hocinehacherouf
force-pushed
the
Feature/2193_redirect_to_login_when_token_expired
branch
from
931ad15 to
7c21766
Compare
kbeaugrand
approved these changes
Jul 21, 2023
…LoginSnackBarIsCreatedAndProblemDetailsExceptionIsThrown
kbeaugrand
force-pushed
the
Feature/2193_redirect_to_login_when_token_expired
branch
from
7c21766 to
d661807
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's new?
What kind of change does this PR introduce?