Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply #18278 to fix TextInput.clear() bug #1

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Apply #18278 to fix TextInput.clear() bug #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions Libraries/Text/TextInput/RCTBaseTextInputView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,28 @@ - (void)setReactBorderInsets:(UIEdgeInsets)reactBorderInsets
[self setNeedsLayout];
}

- (NSString *)text
{
return [self attributedText].string;
}

- (void)setText:(NSString *)text
{
if (self.attributedText.length > 0) {
//copy the attributes
NSRange range = NSMakeRange(self.attributedText.length-1, self.attributedText.length);
NSDictionary *attributes = [self.attributedText attributesAtIndex:0 effectiveRange:&range];
NSMutableAttributedString *newString = [[NSMutableAttributedString alloc] initWithString:text attributes:attributes];
NSMutableAttributedString *primaryStringMutable = [[NSMutableAttributedString alloc] initWithAttributedString:self.attributedText];

//change the string
[primaryStringMutable setAttributedString:newString];
[self setAttributedText:[[NSAttributedString alloc] initWithAttributedString:primaryStringMutable]];
} else {
[self setAttributedText:[[NSAttributedString alloc] initWithString: text]];
}
}

- (NSAttributedString *)attributedText
{
return self.backedTextInputView.attributedText;
Expand Down
1 change: 1 addition & 0 deletions Libraries/Text/TextInput/RCTBaseTextInputViewManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ @implementation RCTBaseTextInputViewManager
RCT_EXPORT_VIEW_PROPERTY(onSelectionChange, RCTDirectEventBlock)
RCT_EXPORT_VIEW_PROPERTY(onTextInput, RCTDirectEventBlock)
RCT_EXPORT_VIEW_PROPERTY(onScroll, RCTDirectEventBlock)
RCT_EXPORT_VIEW_PROPERTY(text, NSString)

RCT_EXPORT_VIEW_PROPERTY(mostRecentEventCount, NSInteger)

Expand Down