Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all mentioning of rbenv from phpenv output #30

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DennisBirkholz
Copy link

Hi Christoph,

my patch replaces all mentioning of rbenv from phpenv (but keeps a reference to rbenv in the help text). Please consider including the patch, thx.

Greets,
Dennis

@glensc
Copy link

glensc commented Nov 30, 2014

This seems incomplete, there are more matches for ruby, like .ruby-version or RUBY_PATH="$(phpenv-which ruby)", so perhaps add such replace:

       -e 's/ruby/php/g' \


phpenv_script() {
local root="$1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove trailing whitespace.

@DennisBirkholz
Copy link
Author

@glensc
My only goal was to fix all mentioning of rbenv when using the commands.
There may be other portions of the code left that refer to ruby or ruby-variables but I tried to avoid changing parts that where out of the scope of my original goal.

@glensc
Copy link

glensc commented Dec 1, 2014

@DennisBirkholz i've managed to do full replacement, and it seems to work excellent:

https://github.com/pld-linux/phpenv/blob/auto/th/phpenv-0.4.0-1/phpenv.spec#L38-L73

i've done some diff -u rbenv phpenv and did not find serious flaws.

comparing to chh/phpenv, such solution supports split trees: code in /usr/share/phpenv, versions in ~/.phpenv intended to make phpenv installable as distribution package.

@DennisBirkholz
Copy link
Author

@glensc I agree with you that a version which completely replaces all ruby/rbenv and supports split trees is preferable. Your .spec-based solution however is limited to RPM based systems. I don't know what the perfect solution for phpenv is however and I don't have the time ATM. Maybe the best way is to generalize rbenv to some scriptenv or langenv that is language agnostic itself and handles languages via configuration and not forking...

@glensc
Copy link

glensc commented Dec 1, 2014

@DennisBirkholz it's not rpm based solutuion. i just inlined the shell script there. if you look closer it's just shell script there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants