Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restart_coszen namelist option #480

Merged
merged 38 commits into from
Jul 17, 2020
Merged

Conversation

dabail10
Copy link
Contributor

@dabail10 dabail10 commented Jul 7, 2020

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    This adds a namelist option for adding coszen to the restart. This removes the need for CESMCOUPLED here.
  • Developer(s):
    dabail10 (D. Bailey)
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_mach_forks#cheyenne
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:
    Several coupled models will need coszen on the restart file. This makes it a namelist option instead of an ifdef.

Mariana Vertenstein and others added 30 commits April 23, 2020 17:43
Update CICE for coupling with UFS
changes to satisfy ufsatm and cesm requirements for pot temp and density from atm
@dabail10
Copy link
Contributor Author

dabail10 commented Jul 9, 2020

See issue #486

Copy link
Contributor

@apcraig apcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see a cpp moved to namelist.

@apcraig
Copy link
Contributor

apcraig commented Jul 15, 2020

@eclare108213, do you want to have a review before we merge?

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do changes also need to be made in io_binary/ice_restart.F90?

I would probably have put this new namelist flag in forcing_nml, since it's for a specific variable. We also have specific restart_[] flags in tracer_nml and zbgc_nml, for example. Maybe we should collect these into a new 'restart_nml' namelist, but not in this PR.

I just noticed an error in the documentation: in doc/source/user_guide_ug_case_settings.rst, please change 'restart' to 'history' in the comments for history_format. Thanks!

@dabail10
Copy link
Contributor Author

Not sure that any coupled models use the binary restarts any longer, but I suppose this is a good plan.

@dabail10
Copy link
Contributor Author

Maybe this is more appropriate in shortwave_nml?

@dabail10
Copy link
Contributor Author

Actually, this is already handled for binary, because it is called from the generic write_restart_field/read_restart_field subroutines that are agnostic to the format. It's almost like someone designed them this way ... :)

@eclare108213
Copy link
Contributor

Maybe this is more appropriate in shortwave_nml?

You could do that. My preference would still be forcing_nml, since coszen really is about the forcing, and the parameters in shortwave_nml are specific to the shortwave parameterizations.

@dabail10
Copy link
Contributor Author

I've moved restart_coszen to the shortwave_nml namelist. I also made the updates to the documentation.

@eclare108213 eclare108213 merged commit b055c7f into CICE-Consortium:master Jul 17, 2020
@dabail10 dabail10 deleted the coszen branch March 24, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants