Update Icepack to 4c42a82, non bit-for-bit changes #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y netcdf file requirements
dabail10
reviewed
Aug 5, 2020
|
I'm happy to bring them in separately, although I'm not sure it provides much advantage. We could demonstrate how each Icepack change separately changes answers, but the Icepack PRs largely do that already as they were tested in CICE independently there. If others think we should separate, just let me know, and I'll take care of it. |
|
Point taken. I have tested the answer changes in standalone Icepack as well as in CICE individually. Both pass the QC control tests. So, I am fine with these going into CICE together if others are. |
dabail10
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Update Icepack to 4c42a82 and remove two tests
apcraig
Not bit-for-bit due to tr_aero fix in Icepack (Old aerosol bug fix (tr_aero). Icepack#330) and snow melt bug fix (Snow melt computation bug. Icepack#328)
Full test results on cheyenne are here, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#6a9672fb5697994e77c1404eba59420791f7326c (with failing tests) and https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#4b963104daaabb25bd0f5f783cfa46c4549b16e3 (with 2 tests removed).
Snow melt computation bug. Icepack#328 documents QC test results which pass for the snow melt bug fix. Old aerosol bug fix (tr_aero). Icepack#330 documents QC test results which pass for the tr_aero bug fix.
Incorporates two important bug fixes from Icepack that are not bit-for-bit,
Also removes two tests that are failing and will not fix. With recent updates to NETCDF implementation, configurations with iobinary that have bathymetry on will fail (as they should). These tests were removed.