Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest NUOPC caps #500

Merged
merged 47 commits into from
Aug 12, 2020
Merged

Latest NUOPC caps #500

merged 47 commits into from
Aug 12, 2020

Conversation

dabail10
Copy link
Contributor

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    These are the latest NUOPC cap changes for CESM and UFS.
  • Developer(s):
    dabail10 (D. Bailey)
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_mach_forks#cheyenne
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:
    This updates the NUOPC caps to work with CICE master (12d16ed). These changes were also tested in UFS and CESM. They are answer changing in these systems as the update to the new CICE hash changed answers.

Mariana Vertenstein and others added 30 commits April 23, 2020 17:43
Update CICE for coupling with UFS
changes to satisfy ufsatm and cesm requirements for pot temp and density from atm
@apcraig
Copy link
Contributor

apcraig commented Aug 12, 2020

I had a quick look at the most recent changes and since they are all in the nuopc cap, think there is no worry for CICE. @dabail10 is this ready to merge or do you have other changes you want to squeeze in?

@dabail10
Copy link
Contributor Author

This is good to go. Thanks!

@apcraig apcraig merged commit eb77517 into CICE-Consortium:master Aug 12, 2020
@mvertens mvertens deleted the nuopc2 branch March 24, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants