Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts: unset executable bit for 'makdep.c' and 'cice.settings' #723

Merged
merged 1 commit into from
May 26, 2022
Merged

scripts: unset executable bit for 'makdep.c' and 'cice.settings' #723

merged 1 commit into from
May 26, 2022

Conversation

phil-blain
Copy link
Member

PR checklist

  • Short (1 sentence) summary of your PR:
    title
  • Developer(s):
    me
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    no code changes - no tests
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

This allows tab-completion for './cice.s[TAB]' to unambiguously complete
to './cice.submit'.

'cice.settings' is designed to be sourced anyway, so it makes little
sense for it to be executable. While at it, also unset the bit for
'makdep.c'.

@phil-blain
scripts: unset executable bit for 'makdep.c' and 'cice.settings'
f5a6f50 
This allows tab-completion for './cice.s[TAB]' to unambiguously complete
to './cice.submit'.

'cice.settings' is designed to be sourced anyway, so it makes little
sense for it to be executable. While at it, also unset the bit for
'makdep.c'.
@phil-blain phil-blain requested a review from apcraig May 24, 2022 19:05
@apcraig apcraig merged commit 317b862 into CICE-Consortium:main May 26, 2022
@phil-blain phil-blain deleted the cice-settings-unchmod-x branch July 4, 2022 20:11
dabail10 pushed a commit to ESCOMP/CICE that referenced this pull request Oct 4, 2022
@phil-blain @dabail10
scripts: unset executable bit for 'makdep.c' and 'cice.settings' (CIC…
1b6437f 
…E-Consortium#723)

This allows tab-completion for './cice.s[TAB]' to unambiguously complete
to './cice.submit'.

'cice.settings' is designed to be sourced anyway, so it makes little
sense for it to be executable. While at it, also unset the bit for
'makdep.c'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apcraig apcraig apcraig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-blain @apcraig