Skip to content

Commit

Permalink
icepack_parameters: don't recompute constants in icepack_query_parame…
Browse files Browse the repository at this point in the history
…ters (#465)

All parameters of icepack_parameters::icepack_query_parameters are
intent(out), so it does not make sense to recompute constants at the end
of that subroutine since no constants are changed. This superfluous call
dates back to the introduction of icepack_query_parameters (then called
icepack_query_constants) in 7646f2a (Migrate icepack_constants out of
the columnphysics/constants directory..., 2017-10-04).

Remove that call.
  • Loading branch information
phil-blain authored Oct 12, 2023
1 parent 45da0b3 commit 182030d
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions columnphysics/icepack_parameters.F90
Original file line number Diff line number Diff line change
Expand Up @@ -1799,9 +1799,6 @@ subroutine icepack_query_parameters( &
if (present(sw_frac_out) ) sw_frac_out = sw_frac
if (present(sw_dtemp_out) ) sw_dtemp_out = sw_dtemp

call icepack_recompute_constants()
if (icepack_warnings_aborted(subname)) return

end subroutine icepack_query_parameters

!=======================================================================
Expand Down

0 comments on commit 182030d

Please sign in to comment.