Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New NCAR hobart changes #210

Merged
merged 2 commits into from
Aug 1, 2018
Merged

New NCAR hobart changes #210

merged 2 commits into from
Aug 1, 2018

Conversation

dabail10
Copy link
Contributor

I have updated Icepack to run with the latest compiler changes on hobart.

  • Developer(s): D. Bailey

  • Please suggest code Pull Request reviewers in the column at right.

  • Are the code changes bit for bit, different at roundoff level, or more substantial? bfb

  • Is the documentation being updated with this PR? (Y/N) N
    If not, does the documentation need to be updated separately at a later time? (Y/N) N
    Note: "Documentation" includes information on the wiki and .rst files in doc/source/,
    which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-icepack/.

  • Other Relevant Details:

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to dynamics_nml in icepack_in? Those parameters are part of the ridging parameterization...

@apcraig
Copy link
Contributor

apcraig commented Jul 30, 2018

@eclare108213, I noticed the missing dynamics_nml too, but assumed it was not needed and was removed intentionally. Glad you caught that!

@dabail10
Copy link
Contributor Author

dabail10 commented Aug 1, 2018

I had meant to just move it rather than deleting it. I will fix this.

Dave

@eclare108213 eclare108213 merged commit fd52cb1 into CICE-Consortium:master Aug 1, 2018
@dabail10 dabail10 deleted the hobart3 branch August 20, 2018 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants