Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cori port due to system upgrade #266

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Jul 30, 2019

PR checklist

  • Short (1 sentence) summary of your PR:
    Update cori modules due to upgrade
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    #943a2d, https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level, only on cori due to compiler upgrade
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Some of the test results are different likely due to the compiler upgrade from intel18 to intel19. No effort was made to validate the new results beyond noting the differences in the test results.

@eclare108213
Copy link
Contributor

The ftp from NCAR failed. How do you resubmit the travis-ci test?

@apcraig
Copy link
Contributor Author

apcraig commented Jul 31, 2019

Look for the button "restart build". There is one in the upper right hand panel on the results page.

It also looks like the format of the travisCI pages changed in the last day or so. I think I like it better.

@apcraig
Copy link
Contributor Author

apcraig commented Jul 31, 2019

travis passed, I'll merge the PR now.

@apcraig apcraig merged commit 50b52d4 into CICE-Consortium:master Jul 31, 2019
lettie-roach pushed a commit to lettie-roach/Icepack that referenced this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants