Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cheyenne compilers #268

Merged
merged 1 commit into from
Aug 8, 2019
Merged

update cheyenne compilers #268

merged 1 commit into from
Aug 8, 2019

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Aug 7, 2019

PR checklist

  • Short (1 sentence) summary of your PR:
    Update the cheyenne compiler/modules
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    https://github.com/CICE-Consortium/Test-Results/wiki/782dc47be7.cheyenne.intel.190807.151906
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit except some cases on cheyenne (as expected)
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

For the record, I tested intel/17.0.1, intel/18.0.5, and intel/19.0.2. We were using the intel/17 version before. This updates to the intel/19 version. The intel/18 version produced several test failures on exact restart. At this point, I think we can assume that's a compiler bug and given intel/19 is available, we can probably ignore it. The problem comes in when someone only has intel/18 and it might produce problems for them. Should we be debugging and working around compiler problems?

@apcraig
Copy link
Contributor Author

apcraig commented Aug 7, 2019

Partly Addresses CICE 329

Copy link
Contributor

@dabail10 dabail10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@apcraig apcraig merged commit a789413 into CICE-Consortium:master Aug 8, 2019
lettie-roach pushed a commit to lettie-roach/Icepack that referenced this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants