Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update icepack_write_parameters #436

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Update icepack_write_parameters #436

merged 1 commit into from
Apr 18, 2023

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Apr 18, 2023

PR checklist

  • Short (1 sentence) summary of your PR:
    Update icepack_write_parameters
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    all tests are bit-for-bit in testing on Cheyenne with Icepack
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Added call in icepack driver to improve test coverage of this subroutine.

Some problems were discovered in E3SM testing with Icepack.

  • Most changes are shifting whitespace (location of =) for cleaner output
  • Added trim to output of character strings
  • Commented out snowage table info, there are problems when the data is not allocated

@apcraig
Update icepack_write_parameters and add call in icepack driver.
d14d983 
Some problems were discovered in E3SM testing with Icepack.
@apcraig apcraig added the IO label Apr 18, 2023
dabail10
dabail10 reviewed Apr 18, 2023
View reviewed changes
columnphysics/icepack_parameters.F90
write(iounit,*) " rhoi = ",rhoi
write(iounit,*) " rhow = ",rhow
write(iounit,*) " cp_air = ",cp_air
write(iounit,*) " rhos = ",rhos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this removing tabs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tabs, just shifting spaces.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is just shifting whitespace?

@apcraig apcraig merged commit b0283b2 into CICE-Consortium:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

@dabail10 dabail10 dabail10 approved these changes

Assignees
No one assigned
Labels
IO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apcraig @eclare108213 @dabail10