Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Icepack optional arguments attribute #443

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Update Icepack optional arguments attribute #443

merged 2 commits into from
Jul 18, 2023

Commits on Jul 18, 2023

  1. Update the optional arguments implementation. Found that passing non-… 

    …scalar optional

arguments down the calling tree without the optional attribute resulted in seg faults
on some machines.  Updated the implementation and documentation to reflect this change.

Cleaned up the rest of the intent lines, so they are not on a new line.
    @apcraig
    apcraig committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    785eb90 View commit details
    Browse the repository at this point in the history

  2. Update documentation

    @apcraig
    apcraig committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    840ef98 View commit details
    Browse the repository at this point in the history