Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Derecho inputdata path, point to campaign #471

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Update Derecho inputdata path, point to campaign #471

merged 1 commit into from
Oct 18, 2023

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Oct 17, 2023

PR checklist

  • Short (1 sentence) summary of your PR:
    Update Derecho inputdata path, point to campaign
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Ran full Icepack test suite on derecho_intel, all tests pass and bit-for-bit.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Also confirmed that the new inputdata directory contains all the same data as the old directory as of today.

@apcraig apcraig requested a review from dabail10 October 17, 2023 22:27
@apcraig
Copy link
Contributor Author

apcraig commented Oct 17, 2023

See CICE-Consortium/CICE#844

@apcraig apcraig merged commit 863b19c into CICE-Consortium:main Oct 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

@dabail10 dabail10 dabail10 approved these changes

Assignees
No one assigned
Labels
Porting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apcraig @eclare108213 @dabail10