Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull request template, Update conda_macos debug flag #484

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Feb 29, 2024

PR checklist

  • Short (1 sentence) summary of your PR:
    Update pull request template, Update conda_macos debug flag
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Tested on mac desktop with os 11.6.4 with latest conda env. All tests pass.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Update pull request template to ask for additional information about the PR. This information can and will be used during the squash merge process to produce more useful commit logs.

Update Macros.conda_macos to remove ffpe-trap=invalid from debug flags.
This flag causes nf90_create to fail with the latest version of
the conda environment. This happens when debug flags are on
and a test with netcdf is turned on. I believe this is a compiler error.

@apcraig apcraig mentioned this pull request Feb 29, 2024
16 tasks
This flag causes nf90_create to fail with the latest version of
the conda environment.  This happens when debug flags are on
and a test with netcdf is turned on.
@apcraig apcraig changed the title Update pull request template to ask for additional information about the PR Update pull request template, Update conda_macos debug flag Feb 29, 2024
@apcraig
Copy link
Contributor Author

apcraig commented Feb 29, 2024

Testing is working again on ghactions. I also duplicated the problem on my mac desktop with the latest conda env and verified the update to the debug flag fixed the error. I think this is a compiler problem. nf90_create seg faults when netcdf+debug is turned on for reasons I was not able to understand. This just started recently and with an update to the conda env, probably a newer version of the gnu compiler.

Feel free to have another look at the PR. Unless I hear any feedback, I'll merge tonight or tomorrow.

@dabail10
Copy link
Contributor

This is weird. I just build the environment today. So, maybe I am not getting the newest somehow?

@apcraig
Copy link
Contributor Author

apcraig commented Feb 29, 2024

@dabail10, I have given up trying to understand the many subtle issues with conda and github actions. My goal is just to keep them functioning as best as I can.

@apcraig apcraig merged commit 3ffde67 into CICE-Consortium:main Mar 1, 2024
2 checks passed
dabail10 pushed a commit to dabail10/Icepack that referenced this pull request Mar 14, 2024
…sortium#484)

Update pull request template to ask for additional information about the PR. This information can and will be used during the squash merge process to produce more useful commit logs.

Update Macros.conda_macos to remove ffpe-trap=invalid from debug flags.
This flag causes nf90_create to fail with the latest version of
the conda environment. This happens when debug flags are on
and a test with netcdf is turned on. I believe this is a compiler error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants