Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code do_RMsynth_3D breaks when modelIcube in pipeline_rmsynth3d is provided #145

Closed
Sebokolodi opened this issue Sep 3, 2024 · 4 comments
Closed

Code do_RMsynth_3D breaks when modelIcube in pipeline_rmsynth3d is provided #145

Sebokolodi opened this issue Sep 3, 2024 · 4 comments

Comments

@Sebokolodi
Copy link
Contributor

When providing modelIcube via pipeline_rmsynth3d, the code fails and gives the following error message

File "/home/lerato/Documents/VLASS/RM-Tools-master/RMtools_3D/do_RMsynth_3D.py", line 253, in run_rmsynth
    FDFcube *= Ifreq0Arr
UnboundLocalError: local variable 'FDFcube' referenced before assignment.
@ErikOsinga
Copy link
Contributor

Do you have not_rmsynth=True?

@ErikOsinga
Copy link
Contributor

ErikOsinga commented Sep 5, 2024 •
edited
Loading

Ah yeah indeed, the POSSUM polarimetry pipeline pipeline_rmsynth3d does not_rmsynth=False and not_rmsynth=True, and it will fail in the second case

@ErikOsinga ErikOsinga mentioned this issue Sep 5, 2024
Merged
@ErikOsinga
Copy link
Contributor

Should be fixed in #146 , now only does the FDF cube normalisation by the I model if the FDF cube was actually computed

@Sebokolodi
Copy link
Contributor Author

Seems to have solved the issue! Closing issue.

Cameron-Van-Eck pushed a commit that referenced this issue Sep 5, 2024
@ErikOsinga
fix issue #145 - rmsynth3d fails when FDF not calculated (#146)
82b00d6 
Fixes issue where running rmsynth3d with not_rmsynth=True and a Stokes I model cube causes a crash, due to the FDF not being created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sebokolodi @ErikOsinga