Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in sample manager #199

Closed
bowring opened this issue Apr 2, 2021 · 1 comment · Fixed by #200
Closed

Bug in sample manager #199

bowring opened this issue Apr 2, 2021 · 1 comment · Fixed by #200
Assignees
Labels

Comments

@bowring
Copy link
Member

bowring commented Apr 2, 2021

Noted by @noahmclean :
Thanks for looking into this. No need for files or data. Just do this. I’ve tried it on three computers – two Macs and One PC. The same thing happens every time.

Open Redux and create a new ID-TIMS sample. So, go to “Sample” -> “New Sample Analysis for ID-TIMS”.
You can keep all the default sample names, values, etc for the new sample. Just create two new fractions and name them z2 and z1, in that order.
Save the Sample (SaveAs Sample, SaveAs for Live Workflow, it doesn’t matter).
This brings you to the main Redux window, looking at the blank data table. The fraction names will now be arranged in alphabetical order.
Click Sample -> Manage Sample. The fractions are now in alphabetical order here. Click Close and Save.
You’re now back at the main Redux window with the blank data table. Fraction names have now been duplicated. If you entered two fractions, z2 and then z1, they are now both labelled z1. If you entered five fractions, there are probably two z1s and two z3s.

Some other observations:

If you create new fractions (by default named F-1 through F-n), as long as the new fraction names are in alphabetical order everything is fine. If any one new fraction is out of order, unpredictable fraction duplication results. So: z1, z2, z3, z4, z5 is fine, and clicking Manage Sample has no effect, but ordering the fractions z5, z1, z2, z3, z4 reproducibly results in the error.
The duplicate fraction names persist when you close and re-open Redux and then re-open a corrupted file.
Sometimes new fractions get created. You might start with five fractions, hit Manage Sample, and end up with seven or eight.
No error or exception is logged to the console when running from the terminal.
The duplicate fraction naming (plus other hijinks) also occurs if you go to New Sample Analysis for ID-TIMS, then hit the Import Fraction Files button and import some existing fraction xml files, again so that they appear out of alphabetical order.

@bowring bowring self-assigned this Apr 2, 2021
@bowring bowring added the bug label Apr 2, 2021
@bowring
Copy link
Member Author

bowring commented Apr 2, 2021

Fixed in release 3.6.93 April 2021

@bowring bowring closed this as completed Apr 2, 2021
bowring added a commit to bowring/ET_Redux that referenced this issue Apr 2, 2021
@bowring bowring mentioned this issue Apr 2, 2021
bowring added a commit that referenced this issue Apr 2, 2021
* Working on it

* Fixed #199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant