Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sensor for number of phases #495

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Add sensor for number of phases #495

merged 1 commit into from
Mar 11, 2024

Conversation

jwillemsen
Copy link
Contributor

Doesn't seem to work on the Zappi class, waiting on CJNE/pymyenergi#23

@jwillemsen
Add sensor for number of phases but that doesn't seem to be supported…
26ad471 
… yet on the Zappi

    * custom_components/myenergi/sensor.py:
@jwillemsen jwillemsen marked this pull request as draft March 11, 2024 11:17
@jwillemsen jwillemsen marked this pull request as ready for review March 11, 2024 20:22
CJNE
CJNE approved these changes Mar 11, 2024
View reviewed changes
Copy link
Owner

@CJNE CJNE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@CJNE CJNE merged commit 9260fa2 into CJNE:main Mar 11, 2024
2 of 4 checks passed
@jwillemsen jwillemsen deleted the jwi-numphases branch March 12, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CJNE CJNE CJNE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwillemsen @CJNE