Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default configuration file output as TOML #435

Merged
merged 2 commits into from
Mar 6, 2020

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Feb 24, 2020

Address the TOML issue in #384.

This PR changes the default config file output to be TOML compliant. It should not change input since input files can be toml or the previous INI format, so this PR is not a breaking change for input configuration and output configuration should be readable on input, but if the configuration is used elsewhere it could be considered a breaking change.

  • add a bunch of tests for toml output and input,
  • update the readme
  • update the book chapter on config
  • tweak the reader to handle both toml and ini for comments and vector input.

@phlptp phlptp added this to the v2.0 milestone Feb 24, 2020
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #435 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #435   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        3582   3583    +1     
=====================================
+ Hits         3582   3583    +1
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️
include/CLI/Config.hpp 100% <100%> (ø) ⬆️
include/CLI/ConfigFwd.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba68040...0bc54fc. Read the comment docs.

@phlptp phlptp requested a review from henryiii February 24, 2020 04:54
@henryiii henryiii merged commit 967bfe0 into CLIUtils:master Mar 6, 2020
@henryiii henryiii deleted the toml_default branch March 6, 2020 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants