Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Atomic types in flags and options #520

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Oct 1, 2020

Fixes #496

dealing with atomic types is kind of a pain.

This PR add support for them. And add the tests for them as well.

The main issue is that atomic types don't support direct assignment only assignment of the underlying type so there was a need to distinguish between the two type in a couple different locations that utilize the wrapper type.

@phlptp phlptp force-pushed the atomic_type_support branch 16 times, most recently from 198eb01 to e4a895f Compare October 1, 2020 17:25
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #520 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #520   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines         3740      3758   +18     
=========================================
+ Hits          3740      3758   +18     
Impacted Files Coverage Δ
include/CLI/App.hpp 100.00% <ø> (ø)
include/CLI/TypeTools.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 438eabe...d68819f. Read the comment docs.

@phlptp phlptp force-pushed the atomic_type_support branch 8 times, most recently from a91dc1f to 04dbdad Compare October 5, 2020 00:20
@phlptp phlptp force-pushed the atomic_type_support branch from 04dbdad to 2dcbf15 Compare October 21, 2020 15:10
@phlptp phlptp force-pushed the atomic_type_support branch from 2dcbf15 to d68819f Compare October 21, 2020 15:14
@henryiii henryiii merged commit 89926dc into CLIUtils:master Oct 28, 2020
@henryiii henryiii deleted the atomic_type_support branch October 28, 2020 15:57
@henryiii
Copy link
Collaborator

Thanks!

@henryiii henryiii added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Oct 28, 2020
@henryiii henryiii added this to the v2.0 milestone Jun 24, 2021
@henryiii henryiii removed needs README Needs to be mentioned in the README needs changelog Hasn't been added to the changelog yet labels Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add_flag doesn't work well with std::atomic<bool>
2 participants