Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstallGenerator options should be consistent with activeadmin #116

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

ilunglee
Copy link
Contributor

@ilunglee ilunglee commented Oct 29, 2021

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behaviour?

Issue Number(s): N/A

What is the new behaviour?

  • rename --skip_action_text to --skip_comments
  • rename --webpacker to --use_webpacker

Other information

N/A

…admin

- rename `--skip_action_text` to `--skip_comments`
- rename `--webpacker` to `--use_webpacker`
@ilunglee ilunglee force-pushed the update_install_generator_option_names branch from 7cdea93 to 5a36c01 Compare October 29, 2021 16:53
@ilunglee ilunglee changed the title fix: install_generator options should be consistent with activeadmin InstallGenerator options should be consistent with activeadmin Oct 29, 2021
@ilunglee ilunglee self-assigned this Oct 29, 2021
@ilunglee ilunglee marked this pull request as ready for review October 29, 2021 17:04
@ilunglee ilunglee merged commit 6e72ebd into main Oct 29, 2021
@ilunglee ilunglee deleted the update_install_generator_option_names branch October 29, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant