Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP tabs render incorrect url #127

Merged
merged 1 commit into from
Nov 3, 2021
Merged

HTTP tabs render incorrect url #127

merged 1 commit into from
Nov 3, 2021

Conversation

ilunglee
Copy link
Contributor

@ilunglee ilunglee commented Nov 3, 2021 •
edited
Loading

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behaviour?

Issue Number(s): N/A

  • base_controller overrides not executing
  • HTTP tabs render incorrect URLs after form submissions with url_for

What is the new behaviour?

  • use ActiveAdmin.after_load to override ActiveAdmin's base_controller
  • add explicit controller and action params to url_for when rendering HTTP tabs

Other information

N/A

@ilunglee
fix: http tabs render incorrect url
3006185 
- base_controller overrides not executing
- http tabs render incorrect urls after form submissions with url_for
@ilunglee ilunglee self-assigned this Nov 3, 2021
@ilunglee ilunglee changed the base branch from v0.2.2-rc to v0.2.2 November 3, 2021 20:04
@ilunglee ilunglee changed the base branch from v0.2.2 to v0.2.2-rc November 3, 2021 20:05
@ilunglee ilunglee changed the title fix: http tabs render incorrect url HTTP tabs render incorrect url Nov 3, 2021
@ilunglee ilunglee added the bug Something isn't working label Nov 3, 2021
@ilunglee ilunglee marked this pull request as ready for review November 3, 2021 20:10
@ilunglee ilunglee merged commit 81ccb74 into v0.2.2-rc Nov 3, 2021
@ilunglee ilunglee deleted the fix/http_tabs_render_incorrect_urls branch November 3, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ilunglee ilunglee

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ilunglee